On Thu, 27 Feb 2014, [email protected] wrote:
From: Michael Niedermayer <[email protected]>
This commits fixes issues that have been revealed with the coverity
scanner in FFmpeg, such as:
- check fseeko() return codes (CID733725)
This part is probably ok
- check return of ftello() (CID739863)
This is mostly a theoretical issue I think, but probably ok to fix anyway,
if it pleases some static analyser.
- fix signedness of variable use to hold return code
Ok
- Check offset_count (CID733836)
Ok
- Fix unintended sign extension of atom_size (CID733810)
This is probably ok
- Fix unintended sign extension of current_offset (CID733809)
This is also probably ok, although it might be easier to fold the cast
into the macro itself instead of adding at every single place it's used.
- add -movflags +faststart note
Probably ok
Signed-off-by: Reinhard Tartler <[email protected]>
---
tools/qt-faststart.c | 45 +++++++++++++++++++++++++++++++++------------
1 file changed, 33 insertions(+), 12 deletions(-)
diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c
index 6522c66..2439bd88 100644
--- a/tools/qt-faststart.c
+++ b/tools/qt-faststart.c
@@ -97,12 +97,13 @@ int main(int argc, char *argv[])
uint64_t i, j;
uint32_t offset_count;
uint64_t current_offset;
- uint64_t start_offset = 0;
+ int64_t start_offset = 0;
unsigned char *copy_buffer = NULL;
int bytes_to_copy;
if (argc != 3) {
- printf("Usage: qt-faststart <infile.mov> <outfile.mov>\n");
+ printf("Usage: qt-faststart <infile.mov> <outfile.mov>\n"
+ "Note: alternatively you can use -movflags +faststart in
ffmpeg\n");
return 0;
}
... in avconv?
I can try to cherrypick these (in separate commits) and post for review,
plus some more sane version of the buffer size increase (I'll see if I can
reproduce such slowness on SD cards).
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
