On Fri, Feb 28, 2014 at 11:05:06AM +0100, Diego Biurrun wrote:
> On Fri, Feb 28, 2014 at 09:41:43AM +0100, Kostya Shishkov wrote:
> > On Thu, Feb 27, 2014 at 02:49:53PM -0800, Diego Biurrun wrote:
> > > It never has different values, so just use the right value directly.
> > > --- a/libavcodec/proresdsp.c
> > > +++ b/libavcodec/proresdsp.c
> > > @@ -86,8 +86,6 @@ av_cold void ff_proresdsp_init(ProresDSPContext *dsp)
> > > #endif
> > > #if CONFIG_PRORES_ENCODER
> > > dsp->fdct = prores_fdct_c;
> > > - dsp->dct_permutation_type = FF_NO_IDCT_PERM;
> > > - ff_init_scantable_permutation(dsp->dct_permutation,
> > > - dsp->dct_permutation_type);
> > > + ff_init_scantable_permutation(dsp->dct_permutation, FF_NO_IDCT_PERM);
> > > #endif
> > > }
> > > --- a/libavcodec/proresdsp.h
> > > +++ b/libavcodec/proresdsp.h
> > > @@ -30,7 +30,6 @@
> > > typedef struct ProresDSPContext {
> > > int idct_permutation_type;
> > > uint8_t idct_permutation[64];
> > > - int dct_permutation_type;
> > > uint8_t dct_permutation[64];
> > > void (* idct_put) (uint16_t *out, int linesize, int16_t *block,
> > > const int16_t *qmat);
> > > void (* fdct) (const uint16_t *src, int linesize, int16_t *block);
> >
> > Not enough, the proper way is to get rid of scantable in encoder entirely,
> > like (not tested though):
>
> Not compiling either, but enough to serve as the hint I was missing to
> remove the whole dct_permutation thing for the encoder. Thanks.
that was the intent
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
