On Fri, Feb 28, 2014 at 12:29:02PM +0200, Martin Storsjö wrote:
> From: Michael Niedermayer <[email protected]>
> 
> qt-faststart doesn't use the normal libav headers at all since
> it's supposed to be a completely standalone tool, so the macro
> is reimplemented here.
> ---
>  tools/qt-faststart.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

I somehow fail to see the point of this.  What's so wrong with using a
libavutil header here?

> --- a/tools/qt-faststart.c
> +++ b/tools/qt-faststart.c
> @@ -37,6 +37,8 @@
>  #define ftello(x)       _ftelli64(x)
>  #endif
>  
> +#define FFMIN(a,b) ((a) > (b) ? (b) : (a))

This should probably just be called MIN if it is not used globally...

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to