Hi, 2014-02-28 9:47 GMT+01:00 Janne Grunau <[email protected]>: > On 2014-02-27 15:54:47 +0100, Christophe Gisquet wrote: >> 2014-02-22 19:59 GMT+01:00 Janne Grunau <[email protected]>: >> > +#define SCALE(c) ((c) / (256.0f * 32768.0f)) >> >> Naming a macro in such a way might collide with something else. > > I would say anything that can't be undefined needs to use a specific > name but everything else is fine with a unspecific name as long as it > is undefined after use. > >> What about DCA_SCALE (only slightly longer) ? > > I would have preferred something shorter but the real clash Diego fixed > for the idct transpose convinced otherwise. I would prefer to not make > it longer since lfe_fir_128 has 4 entries per row and already too long > lines.
ok (I didn't consider those cosmetical remarks blocking anyway) -- Christophe _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
