On 2014-02-28 12:29:01 +0200, Martin Storsjö wrote:
> Copying data in chunks of 1 KB is a little wasteful.
>
> 64 KB should still easily fit on the stack, so there's no need
> to allocate it dynamically.
not that I care but I do not see an advantage of avoiding a additional
heap allocation.
> ---
> tools/qt-faststart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c
> index f33d6fa..88f5b48 100644
> --- a/tools/qt-faststart.c
> +++ b/tools/qt-faststart.c
> @@ -77,7 +77,7 @@
> #define CO64_ATOM QT_ATOM('c', 'o', '6', '4')
>
> #define ATOM_PREAMBLE_SIZE 8
> -#define COPY_BUFFER_SIZE 1024
> +#define COPY_BUFFER_SIZE 65536
>
> int main(int argc, char *argv[])
> {
patch ok
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
