On Wed, 26 Feb 2014 01:49:14 +0100, Vittorio Giovara <[email protected]> wrote: > On Tue, Feb 25, 2014 at 11:32 AM, Kostya Shishkov > <[email protected]> wrote: > > On Tue, Feb 25, 2014 at 11:27:09AM +0100, Anton Khirnov wrote: > >> > >> On Thu, 20 Feb 2014 00:13:35 +0100, Vittorio Giovara > >> <[email protected]> wrote: > >> > > >> > Is it worthwhile to reuse some of the showinfo functions in the avconv > >> > output too? > >> > >> ??? > >> In what form > > > > Stream #0.1(cz): Audio: ac3, 48000 Hz, 5.1, fltp, 448 kb/s (default) > > Metadata: > > title : AC3 Audio > > Side data: > > replaygain : 1 0 1 0 > > > Exactly! > Maybe each side data file could have its own "av_side_data_dumper" > function that prints the relevant information or just prepares the > strings. > So, in (for example) stereo3d.c there would be a av_stereo3d_dump > function (or similar) that vf_showinfo and avconv (and possibly users) > might call. > In this way the functions would be closer to the original source of > side data and more easily found when adding new values or modifying > old ones.
I do not believe this is such a great idea, the printing format ends up specifically tailored to just one caller. avconv/showinfo are better places for this IMO -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
