On 06/03/14 08:44, Martin Storsjö wrote:
> It would be appreciated if these could be split into one commit per
> feature (subsequent changes/fixes to that feature squashed into it) -
> it's really hard to review them when they're all batched together like
> this. I don't have time to do it myself right now, but if nobody else
> steps up to do it I might have time in a few days.

+1

From a cursory look, av_get_token would work a little better than
strtok_r and probably some of this code should be factored in a function
instead of having many variables around for the seekable check. (not
sure if we can be "smarter" and switch to non-seekable by a direct
heuristic)

Thanks to Alessandro for doing most of the hard work!

lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to