On Thu, Mar 6, 2014 at 9:17 PM, Tim Walker <[email protected]> wrote: > On 06 Mar 2014, at 16:27, Hendrik Leppkes <[email protected]> wrote: > >> On Thu, Mar 6, 2014 at 4:03 PM, Luca Barbato <[email protected]> wrote: >>> On 06/03/14 15:59, Felix Abecassis wrote: >>>> Without this patch, I have the following output with VLC using DXVA2 >>>> MPEG-2: >>>> http://imgur.com/HdMVAx9 >>>> With this patch, the problem seems to be solved. >>>> >>>> I'm simply suggesting a backport so I can't help you further with the >>>> ins and outs of this patch :) >>> >>> Ok. basically you need more slice to fill a whole frame properly. >>> >>> I need some information to put in the commit message. >>> >>> DXVA experts can chip in and/or propose a patch to make that context a >>> little saner (discussion about breaking ABI are mooth). >> >> This is a private context, so not part of the ABI - so you are right, >> the discussion is pointless :P >> >> Other ideas are to dynamically alloc it as needed, but since there is >> no sane way to "remember" the number of slices from frame to frame >> right now, it would mean many many reallocs for every frame, just to >> potentially save a few bytes of memory - so it does not seem worth it. >> I've never hit a file with more then 1024 slices. >> >> - Hendrik > > Did you ever hit one with 1024 slices? That sounds excessive regardless of > resolution, would love to see such a sample. >
No. If i had, I would've gone higher. Hardware decoding uses basically no system memory as it is, so worrying about mere kilobytes of memory didn't seem worth it, and a safe high value was used. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
