On 07/03/14 18:48, Luca Barbato wrote: > On 07/03/14 17:47, Vittorio Giovara wrote: >> From: Michael Niedermayer <[email protected]> >> >> Fixes use of uninitialized memory and out of stack array read. >> Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind >> --- >> libavcodec/hevc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c >> index fc62024..a78ea8e 100644 >> --- a/libavcodec/hevc.c >> +++ b/libavcodec/hevc.c >> @@ -212,7 +212,7 @@ static int pic_arrays_init(HEVCContext *s, const HEVCSPS >> *sps) >> goto fail; >> >> s->cbf_luma = av_malloc(sps->min_tb_width * sps->min_tb_height); >> - s->tab_ipm = av_malloc(min_pu_size); >> + s->tab_ipm = av_mallocz(min_pu_size); >> s->is_pcm = av_malloc(min_pu_size); >> if (!s->tab_ipm || !s->cbf_luma || !s->is_pcm) >> goto fail; >> > > Are you sure this is the only table that should be 0-initialized? >
Short of severely malformed bitstream (and our parser not cutting it) that should be the only one not resetted by frame_start. The change itself looks ok to me as well, in case you were wondering. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
