On 10 Mar 2014, at 13:24, Luca Barbato <[email protected]> wrote: > On 10/03/14 12:43, Tim Walker wrote: >> >> On 10 Mar 2014, at 11:01, Luca Barbato <[email protected]> wrote: >> >>> Do not use inline functions that refer to tables present in other >>> libraries. --- libavformat/hevc.c | 10 +++++----- 1 file changed, 5 >>> insertions(+), 5 deletions(-) >> >> I used get_se_golomb because the spec. said those fields were se(v) >> and I was unsure whether get_ue_golomb/get_ue_golomb_long would read >> the correct number of bits (I really had no clue what I was doing). > > se or ue are just the same encoding in the bitstream, you just use the > first bit as sign. > >> But it seems your get_se_golomb_long just uses get_ue_golomb_long - >> were's skipping these fields anyway, is there any difference in >> behavior or does it just make it obvious we're skipping signed golomb >> codes? > > mostly for completeness sake and prevent more cases in the future. > > lu
Out of curiosity, what does get_se_golomb do which requires a table that we don't need in a "get_se_golomb_long" implementation? Tim _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
