On 10/03/14 11:55 PM, Tim Walker wrote:
> On 11 Mar 2014, at 03:38, James Almer <[email protected]> wrote:
>
>> On 10/03/14 11:37 AM, Diego Biurrun wrote:
>>> ---
>>> libavformat/apetag.c | 6 ++++--
>>> libavformat/asfdec.c | 8 +++++---
>>> libavformat/avidec.c | 4 ++--
>>> libavformat/bink.c | 10 +++++++---
>>> libavformat/cafdec.c | 5 ++++-
>>> libavformat/crcenc.c | 4 +++-
>>> libavformat/dfa.c | 7 +++++--
>>> libavformat/dxa.c | 5 ++++-
>>> libavformat/electronicarts.c | 8 +++++---
>>> libavformat/framecrcenc.c | 4 +++-
>>> libavformat/gxf.c | 6 +++++-
>>> libavformat/hnm.c | 11 +++++++----
>>> libavformat/iff.c | 4 +++-
>>> libavformat/lxfdec.c | 9 ++++++---
>>> libavformat/matroskadec.c | 3 ++-
>>> libavformat/mov.c | 7 ++++---
>>> libavformat/mvi.c | 5 ++++-
>>> libavformat/mxfdec.c | 13 ++++++++-----
>>> libavformat/omadec.c | 8 +++++---
>>> libavformat/rmdec.c | 4 +++-
>>> libavformat/rpl.c | 4 ++--
>>> libavformat/smacker.c | 8 ++++++--
>>> libavformat/smjpegdec.c | 8 +++++---
>>> libavformat/spdifenc.c | 8 +++++---
>>> libavformat/wtv.c | 6 ++++--
>>> libavformat/xmv.c | 6 +++---
>>> 26 files changed, 114 insertions(+), 57 deletions(-)
>>
>> [...]
>>
>>> @@ -539,14 +539,15 @@ static int mxf_read_partition_pack(void *arg,
>>> AVIOContext *pb, int tag, int size
>>> }
>>>
>>> if (partition->kag_size <= 0 || partition->kag_size > (1 << 20)) {
>>> - av_log(mxf->fc, AV_LOG_WARNING, "invalid KAGSize %i - guessing ",
>>> partition->kag_size);
>>> + av_log(mxf->fc, AV_LOG_WARNING, "invalid KAGSize %"PRId32" -
>>> guessing ",
>>> + partition->kag_size);
>>
>> PRIi32? Ditto for any similar case.
>
> Same result, but %d/%"PRId32" are more commonly used than %i/%"PRIi32"
>
Fair enough. It was mostly a nit to keep the same specifier after expansion.
>>
>> [...]
>>
>>> @@ -501,7 +503,7 @@ static void get_tag(AVFormatContext *s, AVIOContext
>>> *pb, const char *key, int ty
>>> return;
>>>
>>> if (type == 0 && length == 4) {
>>> - snprintf(buf, buf_size, "%"PRIi32, avio_rl32(pb));
>>> + snprintf(buf, buf_size, "%u", avio_rl32(pb));
>>
>> Isn't this doing the opposite of what the patch was meant to do?
>
> No, avio_rl32 returns unsigned int, not uint32_t, so %u is the correct
> specifier.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
