On Tue, 11 Mar 2014, Luca Barbato wrote:

From: Anssi Hannula <[email protected]>

Signed-off-by: Luca Barbato <[email protected]>
---
doc/protocols.texi |  6 ++++++
libavformat/http.c | 17 ++++++++++++++---
2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/doc/protocols.texi b/doc/protocols.texi
index 4a98550..ffbb742 100644
--- a/doc/protocols.texi
+++ b/doc/protocols.texi
@@ -114,6 +114,12 @@ If the server supports ICY metadata, and @option{icy} was 
set to 1, this
contains the last non-empty metadata packet sent by the server. It should be
polled in regular intervals by applications interested in metadata updates
mid-stream.
+
+@item offset
+Set initial byte offset.
+
+@item end_offset
+Try to limit the request to bytes preceding this offset.
@end table

@section mmst
diff --git a/libavformat/http.c b/libavformat/http.c
index d06086e..c317fa9 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -51,7 +51,7 @@ typedef struct {
    int http_code;
    /* Used if "Transfer-Encoding: chunked" otherwise -1. */
    int64_t chunksize;
-    int64_t off, filesize;
+    int64_t off, end_off, filesize;
    char *location;
    HTTPAuthState auth_state;
    HTTPAuthState proxy_auth_state;
@@ -106,6 +106,8 @@ static const AVOption options[] = {
{"basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, {.i64 = HTTP_AUTH_BASIC}, 0, 
0, D|E, "auth_type" },
{"send_expect_100", "Force sending an Expect: 100-continue header for POST", 
OFFSET(send_expect_100), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 1, E },
{"location", "The actual location of the data received", OFFSET(location), 
AV_OPT_TYPE_STRING, { 0 }, 0, 0, D|E },
+{"offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, {.i64 = 0}, 
0, INT64_MAX, D },
+{"end_offset", "try to limit the request to bytes preceding this offset", 
OFFSET(end_off), AV_OPT_TYPE_INT64, {.i64 = 0}, 0, INT64_MAX, D },
{NULL}
};
#define HTTP_CLASS(flavor)\
@@ -571,9 +573,18 @@ static int http_connect(URLContext *h, const char *path, 
const char *local_path,
    if (!has_header(s->headers, "\r\nAccept: "))
        len += av_strlcpy(headers + len, "Accept: */*\r\n",
                          sizeof(headers) - len);
-    if (!has_header(s->headers, "\r\nRange: ") && !post)
+    // Note: we send this on purpose even when s->off is 0 when we're probing,
+    // since it allows us to detect more reliably if a (non-conforming)
+    // server supports seeking by analysing the reply headers.

This comment actually originated from Reimar (in an unrelated patch, see 033f53fb) - and this patch doesn't really change anything wrt to the comment (no more need to mention it now than before). But the comment itself is good, so I guess it can be kept in this patch, but mention Reimar in the commit message as well. (Sorry for not pointing this out earlier.)

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to