On Wed, Mar 12, 2014 at 8:21 AM, Anton Khirnov <[email protected]> wrote:
>
> On Fri, 7 Mar 2014 11:56:24 +0100, Vittorio Giovara
> <[email protected]> wrote:
>> - s->cur_pic = NULL;
>> - s->next_pic = NULL;
>> - s->last_pic = NULL;
>
> To be extra safe you could clear those structs here, but I suppose it's not
> strictly necessary.
Well I just added
memset(&s->cur_pic, 0, sizeof(ERPicture));
memset(&s->last_pic, 0, sizeof(ERPicture));
memset(&s->next_pic, 0, sizeof(ERPicture));
to be extra safe.
> Patch LGTM
For extra clarity on what the new function does, I would rename it
ff_mpeg_set_erpic(), if no objections.
(I can revert or change it again if anyone insists).
Thanks for the review.
Vittorio
>
> --
> Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
