On Fri, 14 Mar 2014 05:42:23 -0700, Diego Biurrun <[email protected]> wrote:
> ---
>  libavcodec/bfin/vp3dsp_init.c   | 2 +-
>  libavcodec/bit_depth_template.c | 1 +
>  libavcodec/cavsdsp.c            | 2 ++
>  libavcodec/dsputil.h            | 7 +------
>  libavcodec/imgconvert.c         | 2 +-
>  libavcodec/indeo4data.h         | 3 ++-
>  libavcodec/mathops.h            | 4 ++++
>  libavcodec/mathtables.c         | 4 +++-
>  libavcodec/mss3.c               | 2 +-
>  libavcodec/pgssubdec.c          | 2 +-
>  libavcodec/rv30dsp.c            | 1 +
>  libavcodec/rv40dsp.c            | 1 +
>  libavcodec/vp3.c                | 2 +-
>  libavcodec/vp8dsp.c             | 2 +-
>  14 files changed, 21 insertions(+), 14 deletions(-)
> 

Why is that a better place?

> diff --git a/libavcodec/bfin/vp3dsp_init.c b/libavcodec/bfin/vp3dsp_init.c
> index ae7ce93..be77cc4 100644
> --- a/libavcodec/bfin/vp3dsp_init.c
> +++ b/libavcodec/bfin/vp3dsp_init.c
> @@ -23,8 +23,8 @@
>  
>  #include "libavutil/attributes.h"
>  #include "libavcodec/avcodec.h"
> +#include "libavcodec/mathops.h"
>  #include "libavcodec/vp3dsp.h"
> -#include "libavcodec/dsputil.h"
>  
>  void ff_bfin_vp3_idct(int16_t *block);
>  
> diff --git a/libavcodec/bit_depth_template.c b/libavcodec/bit_depth_template.c
> index 79bbbbb..27e658b 100644
> --- a/libavcodec/bit_depth_template.c
> +++ b/libavcodec/bit_depth_template.c
> @@ -16,6 +16,7 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
> USA
>   */
>  
> +#include "mathops.h"
>  #include "rnd_avg.h"
>  
>  #ifndef BIT_DEPTH
> diff --git a/libavcodec/cavsdsp.c b/libavcodec/cavsdsp.c
> index bc90546..666dc7f 100644
> --- a/libavcodec/cavsdsp.c
> +++ b/libavcodec/cavsdsp.c
> @@ -23,7 +23,9 @@
>   */
>  
>  #include <stdio.h>
> +
>  #include "dsputil.h"
> +#include "mathops.h"
>  #include "cavsdsp.h"
>  #include "libavutil/common.h"
>  
> diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h
> index 10479f9..b712d49 100644
> --- a/libavcodec/dsputil.h
> +++ b/libavcodec/dsputil.h
> @@ -36,16 +36,11 @@
>  /* encoding scans */
>  extern const uint8_t ff_alternate_horizontal_scan[64];
>  extern const uint8_t ff_alternate_vertical_scan[64];
> -extern const uint8_t ff_zigzag_direct[64];
>  extern const uint8_t ff_zigzag248_direct[64];

Why one and not the other?

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to