On 2014-03-19 16:25:10 +0200, Martin Storsjö wrote:
> On Wed, 19 Mar 2014, Janne Grunau wrote:
>
> >Although it is allowed it does not make much sense since the immediate
> >is already 8bits.
> >---
> >gas-preprocessor.pl | 2 +-
> >1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
> >index 914c41c..692e788 100755
> >--- a/gas-preprocessor.pl
> >+++ b/gas-preprocessor.pl
> >@@ -758,7 +758,7 @@ sub handle_serialized_line {
> > $line = " orr $1, $2, $2\n";
> > }
> > # movi 8, 16, 32 bit shifted variant, shift is optional
> >- if ($line =~
> >/^\s*movi\s+(v[0-3]?\d\.(?:2|4|8|16)[bhsBHS])\s*,\s*(#\w+)\b\s*$/) {
> >+ if ($line =~
> >/^\s*movi\s+(v[0-3]?\d\.(?:2|4|8)[hsHS])\s*,\s*(#\w+)\b\s*$/) {
> > $line = " movi $1, $2, lsl #0\n";
>
> Should the 8 bit be removed from the comment above as well?
yes
> The patch itself is probably ok, I didn't ever look deeply into the
> issue this worked around.
no averse effects on libav aarch64 build. I'll push with changed comment
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
