On 19/03/14 18:34, Diego Biurrun wrote:
> ---
> 
> Amended to not break some long lines for enhanced readability.

Readability remains impaired.

> +#define HPELDSP_AVG_PIXELS16(CPUEXT)                      \
> +    CALL_2X_PIXELS(put_no_rnd_pixels16_x2 ## CPUEXT, 
> ff_put_no_rnd_pixels8_x2 ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(put_pixels16_y2        ## CPUEXT, ff_put_pixels8_y2       
>  ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(put_no_rnd_pixels16_y2 ## CPUEXT, 
> ff_put_no_rnd_pixels8_y2 ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(avg_pixels16           ## CPUEXT, ff_avg_pixels8          
>  ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(avg_pixels16_x2        ## CPUEXT, ff_avg_pixels8_x2       
>  ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(avg_pixels16_y2        ## CPUEXT, ff_avg_pixels8_y2       
>  ## CPUEXT, 8) \
> +    CALL_2X_PIXELS(avg_pixels16_xy2       ## CPUEXT, ff_avg_pixels8_xy2      
>  ## CPUEXT, 8)
>  
>  HPELDSP_AVG_PIXELS16(_3dnow)
>  HPELDSP_AVG_PIXELS16(_mmxext)
> diff --git a/libavcodec/x86/rnd_mmx.c b/libavcodec/x86/rnd_mmx.c
> index f5239fc..720d88f 100644
> --- a/libavcodec/x86/rnd_mmx.c
> +++ b/libavcodec/x86/rnd_mmx.c
> @@ -17,6 +17,7 @@
>   */
>  
>  #include "config.h"
> +#include "libavcodec/pixels.h"
>  #include "dsputil_x86.h"
>  #include "inline_asm.h"
>  
> @@ -30,7 +31,7 @@
>  
>  #include "rnd_template.c"
>  
> -PIXELS16(, ff_avg, , _xy2, _mmx)
> -PIXELS16(, ff_put, , _xy2, _mmx)
> +CALL_2X_PIXELS_EXPORT(ff_avg_pixels16_xy2_mmx, ff_avg_pixels8_xy2_mmx, 8)
> +CALL_2X_PIXELS_EXPORT(ff_put_pixels16_xy2_mmx, ff_put_pixels8_xy2_mmx, 8)
>  
>  #endif /* HAVE_INLINE_ASM */
> 

Do not replace PIXELS16. just implement PIXELS16 with CALL_2X_PIXELS_EXPORT.



_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to