On Sat, 22 Mar 2014 14:27:28 +0100, Vittorio Giovara 
<[email protected]> wrote:
> On Friday, March 21, 2014, wm4 <[email protected]> wrote:
> 
> > Inspired by FFmpeg changes and koda's patches.
> 
> 
> the commit log would be fine even without this.
> 
> 
> > ---
> >  doc/APIchanges       |  5 +++
> >  libavcodec/avcodec.h | 67 --------------------------------------
> >  libavutil/frame.c    | 10 ++++++
> >  libavutil/frame.h    | 92
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  libavutil/version.h  |  2 +-
> >  5 files changed, 108 insertions(+), 68 deletions(-)
> >
> 
> This change is fine wight me, however I feel that frame.h is becoming
> slightly crammed.
> The only edit I would ask it to move the enums to a separate header, like
> colormodel.h or something, and let relevant files use it directly.
> 

Why not pixfmt.h (or pixdesc.h, I don't quite understand why those are
separate). Those seem like the appropriate place.

frame.h is not very appropriate, given that those enums would be used in other
places than AVFrame

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to