On Tue, Mar 25, 2014 at 09:39:24AM +0100, Vittorio Giovara wrote:
> ---
>  libavfilter/vf_transpose.c | 56 
> +++++++++++++++++++++++++---------------------
>  1 file changed, 30 insertions(+), 26 deletions(-)

I'd suggest to reorder includes while you're at it.

> --- a/libavfilter/vf_transpose.c
> +++ b/libavfilter/vf_transpose.c
> @@ -225,14 +229,14 @@ static const AVFilterPad 
> avfilter_vf_transpose_outputs[] = {
>  
>  AVFilter ff_vf_transpose = {
> -    .name      = "transpose",
> +    .name        = "transpose",
>      .description = NULL_IF_CONFIG_SMALL("Transpose input video."),
>  
> -    .priv_size = sizeof(TransContext),
> +    .priv_size  = sizeof(TransContext),
>      .priv_class = &transpose_class,
>  
>      .query_formats = query_formats,
>  
> -    .inputs    = avfilter_vf_transpose_inputs,
> -    .outputs   = avfilter_vf_transpose_outputs,
> +    .inputs  = avfilter_vf_transpose_inputs,
> +    .outputs = avfilter_vf_transpose_outputs,
>  };

I think you could align all of the = at the same position while you're
at it.

LGTM

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to