On Mon, Mar 24, 2014 at 02:00:34AM +0100, Vittorio Giovara wrote:
> On Thu, Mar 20, 2014 at 3:02 AM, Tanja Batchelor
> > --- a/libavformat/mpeg.c
> > +++ b/libavformat/mpeg.c
> > @@ -390,41 +390,41 @@ static int mpegps_read_packet(AVFormatContext *s,
> > if (len < 0)
> > return len;
> >
> > - if(startcode == 0x1bd) {
> > + if (startcode == 0x1bd) {
> > dvdaudio_substream_type = avio_r8(s->pb);
> > avio_skip(s->pb, 3);
> > len -= 4;
> > }
>
> The kind of nits here are for your improvement, I'll push a correct version.
Actually, having OPW candidates amend and resend patches is a good exercise.
Sending patches is good, going through a complete send, review, revise, and
resend cycle is better. Please don't take that opportunity away from OPW
candidates :)
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
