On Tue, 25 Mar 2014, Tanja Batchelor wrote:
---
libavformat/srtp.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavformat/srtp.c b/libavformat/srtp.c
index 6659bfc..9f4aa36 100644
--- a/libavformat/srtp.c
+++ b/libavformat/srtp.c
@@ -17,7 +17,7 @@
* You should have received a copy of the GNU Lesser General Public
* License along with Libav; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
+ */
This adds a trailing whitespace, which is forbidden. What was the purpose
of this part of the change?
#include "libavutil/base64.h"
#include "libavutil/aes.h"
@@ -28,6 +28,9 @@
#include "rtpdec.h"
#include "srtp.h"
+// printf is used purposefully in this file
+// for printing to stdout instead of stderr
+
void ff_srtp_free(struct SRTPContext *s)
{
if (!s)
@@ -400,7 +403,7 @@ static void print_data(const uint8_t *buf, int len)
{
int i;
for (i = 0; i < len; i++)
- printf("%02x", buf[i]);
+ printf("%02x", buf[i]);
This was previously correctly indented with 8 spaces, now it's changed to
9 which is wrong. Why did you think this had to be changed?
printf("\n");
}
@@ -430,8 +433,8 @@ static void test_encrypt(const uint8_t *data, int in_len,
const char *suite,
else
printf("Decrypted content doesn't match input\n");
} else {
- printf("Decryption failed\n");
- }
+ printf("Decryption failed\n");
+ }
This was previously indented correctly, with the brace at 4 spaces and the
printf at 8 spaces indentation - why should this be changed?
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
