On Wed, Mar 26, 2014 at 8:39 PM, Diego Biurrun <[email protected]> wrote: > On Wed, Mar 26, 2014 at 05:48:52PM +0100, Vittorio Giovara wrote: >> --- a/libavcodec/vp8.c >> +++ b/libavcodec/vp8.c >> @@ -437,7 +451,8 @@ static int decode_frame_header(VP8Context *s, const >> uint8_t *buf, int buf_size) >> >> -static av_always_inline void clamp_mv(VP8Context *s, VP56mv *dst, const >> VP56mv *src) >> +static av_always_inline >> +void clamp_mv(VP8Context *s, VP56mv *dst, const VP56mv *src) > > We mostly break this at the comma.
well the "style" of the file seemed to prefer having attributes on a separate line, and this helps in not breaking arguments of the function. >> @@ -1411,36 +1457,41 @@ static av_always_inline void idct_mb(VP8Context *s, >> VP8ThreadData *td, >> } >> } >> -chroma_idct_end: ; >> +chroma_idct_end:; > > WTH? > > I suggest (separately) dropping this empty statement. > Will do. >> @@ -299,184 +312,198 @@ static void vp8_h_loop_filter_simple_c(uint8_t *dst, >> ptrdiff_t stride, int flim) >> #define VP8_MC_FUNC(IDX, SIZE) \ >> - dsp->put_vp8_epel_pixels_tab[IDX][0][0] = put_vp8_pixels ## SIZE ## _c; >> \ >> - dsp->put_vp8_epel_pixels_tab[IDX][0][1] = put_vp8_epel ## SIZE ## >> _h4_c; \ >> - dsp->put_vp8_epel_pixels_tab[IDX][0][2] = put_vp8_epel ## SIZE ## >> _h6_c; \ >> - dsp->put_vp8_epel_pixels_tab[IDX][1][0] = put_vp8_epel ## SIZE ## >> _v4_c; \ >> + dsp->put_vp8_epel_pixels_tab[IDX][0][0] = put_vp8_pixels ## SIZE ## _c; >> \ >> + dsp->put_vp8_epel_pixels_tab[IDX][0][1] = put_vp8_epel ## SIZE ## >> _h4_c; \ >> + dsp->put_vp8_epel_pixels_tab[IDX][0][2] = put_vp8_epel ## SIZE ## >> _h6_c; \ >> + dsp->put_vp8_epel_pixels_tab[IDX][1][0] = put_vp8_epel ## SIZE ## >> _v4_c; \ >> dsp->put_vp8_epel_pixels_tab[IDX][1][1] = put_vp8_epel ## SIZE ## >> _h4v4_c; \ >> dsp->put_vp8_epel_pixels_tab[IDX][1][2] = put_vp8_epel ## SIZE ## >> _h6v4_c; \ >> - dsp->put_vp8_epel_pixels_tab[IDX][2][0] = put_vp8_epel ## SIZE ## >> _v6_c; \ >> + dsp->put_vp8_epel_pixels_tab[IDX][2][0] = put_vp8_epel ## SIZE ## >> _v6_c; \ >> dsp->put_vp8_epel_pixels_tab[IDX][2][1] = put_vp8_epel ## SIZE ## >> _h4v6_c; \ >> dsp->put_vp8_epel_pixels_tab[IDX][2][2] = put_vp8_epel ## SIZE ## >> _h6v6_c > > Either align the \ or don't change it. The \ are now aligned on the 79th column or the closest possible location, and this is valid for the whole file. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
