On Thu, Mar 27, 2014 at 8:11 AM, Jason Garrett-Glaser <[email protected]> wrote: > On Wed, Mar 26, 2014 at 6:53 PM, Vittorio Giovara > <[email protected]> wrote: >> --- >> libavcodec/vp8.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c >> index 30e24cc..5d41704 100644 >> --- a/libavcodec/vp8.c >> +++ b/libavcodec/vp8.c >> @@ -1428,7 +1428,7 @@ static av_always_inline void idct_mb(VP8Context *s, >> VP8ThreadData *td, >> s->vp8dsp.vp8_idct_add(ch_dst+4*x, >> td->block[4+ch][(y<<1)+x], s->uvlinesize); >> nnz4 >>= 8; >> if (!nnz4) >> - goto chroma_idct_end; >> + return; >> } >> ch_dst += 4*s->uvlinesize; >> } >> @@ -1436,7 +1436,6 @@ static av_always_inline void idct_mb(VP8Context *s, >> VP8ThreadData *td, >> s->vp8dsp.vp8_idct_dc_add4uv(ch_dst, td->block[4+ch], >> s->uvlinesize); >> } >> } >> -chroma_idct_end: ; > > This patch is incorrect. Note that it does not jump to the end of the > function; it jumps to the end of the loop. >
Right, sorry for the noise. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
