On Thu, Mar 20, 2014 at 11:37 AM, James Almer <[email protected]> wrote: > Build only on x86_32 targets. > > Signed-off-by: James Almer <[email protected]> > --- > libavcodec/x86/dcadsp.asm | 55 > +++++++++++++++++++++++++++++++++----------- > libavcodec/x86/dcadsp_init.c | 45 ++++++++++++++++++++++-------------- > 2 files changed, 70 insertions(+), 30 deletions(-) > > diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm > index 56039ba..970ec3d 100644 > --- a/libavcodec/x86/dcadsp.asm > +++ b/libavcodec/x86/dcadsp.asm > @@ -199,15 +199,31 @@ INIT_XMM sse > DCA_LFE_FIR 0 > DCA_LFE_FIR 1 > > -INIT_XMM sse2 > +%macro SETZERO 1 > +%if cpuflag(sse2) > + pxor %1, %1 > +%else > + xorps %1, %1, %1 > +%endif > +%endmacro
Is there some reason we can't just use xorps here for all versions? I mean, it is float data, right? > %if ARCH_X86_32 || WIN64 > +%if cpuflag(sse2) > movd scale, scalem > +%else > + movss scale, scalem > +%endif Same here; does this need to be ifdeffed? Otherwise looks okay. Jason _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
