On Thu, 3 Apr 2014 11:34:17 +0200, Vittorio Giovara 
<[email protected]> wrote:
> On Wed, Apr 2, 2014 at 7:17 PM, Anton Khirnov <[email protected]> wrote:
> >> +        pkt->stream_index = mv->stream_index;
> >> +        pkt->pts = index->timestamp;
> >> +        pkt->flags |= AV_PKT_FLAG_KEY;
> >> +
> >> +        mv->frame[mv->stream_index]++;
> >> +        mv->eof_count = 0;
> >> +    } else {
> >> +        mv->eof_count++;
> >> +        if (mv->eof_count >= avctx->nb_streams)
> >> +            return AVERROR_EOF;
> >
> > This looks shady. If one stream EOFs, it should retry another one, not 
> > return 0
> > without a packet.
> 
> I fixed the other comments but I don't understand this one.
> How should demux end?

Unless I failed a read check, when the else branch is taken, the demuxer will
return 0 without a packet being read. That should not happen.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to