On Sat, Apr 05, 2014 at 04:59:21PM +0200, Janne Grunau wrote:
> On 2014-04-05 14:35:00 +0200, Diego Biurrun wrote:
> > On Sat, Apr 05, 2014 at 02:16:47PM +0200, Janne Grunau wrote:
> > > From: Janne Grunau <[email protected]>
> > > 
> > > ---
> > >  libavutil/aarch64/cpu.c | 3 ++-
> > >  libavutil/aarch64/cpu.h | 1 +
> > >  libavutil/cpu.c         | 2 ++
> > >  libavutil/cpu.h         | 1 +
> > >  4 files changed, 6 insertions(+), 1 deletion(-)
> > 
> > Why don't you add a HAVE_ARMV8 variable?
> 
> because it's always true when targeting ARCH_AARCH64. The whole ARMV8
> flag is questionable and only useful for ensuring that '-cpuflags none'
> runs the same compiled code on each architecture.
> 
> But I fear I need it anyway for building without external assembler.

So go ahead and add it.  Some of the code you wrote here would get
simplified as a bonus.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to