On Sat, 05 Apr 2014 11:22:15 -0400, Justin Ruggles <[email protected]> 
wrote:
> On 04/04/2014 11:49 AM, Anton Khirnov wrote:
> > ---
> >  libavformat/Makefile |    2 +-
> >  libavformat/mov.c    |   99 
> > +++++++++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 99 insertions(+), 2 deletions(-)
> [...]
> > +static int mov_read_replaygain(MOVContext *c, AVIOContext *pb, int size)
> > +{
> > +    int64_t end = avio_tell(pb) + size;
> > +    uint8_t *key = NULL, *val = NULL;
> > +    int i;
> > +
> > +    for (i = 0; i < 2; i++) {
> > +        uint8_t **p;
> > +        uint32_t len, tag;
> > +
> > +        if (end - avio_tell(pb) <= 16)
> > +            break;
> 
> This is the only part I don't get. Why 16? Is the key required to have a
> length of at least 4?

Good catch, that's a remnant from an older version.
Changed to 12 locally.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to