On 09 Apr 2014, at 15:30, Derek Buitenhuis <[email protected]> wrote:
> On 4/9/2014 12:42 AM, Tim W. wrote: >> IIRC H.265 has 16-bit fields for SAR width/height: strlen(65535) * 2 + ':' + >> '\n' should be 12, IMO. > > Well we are calling av_reduce with a max of 4096. > > Nobody mentioned this originally. > > I'll do it in a separate patch if this is true. Oh, didn't notice that. Checked the specification, sar_width and sar_height are definitely u(16), and nothing in H.265 restricts their value beyond the fact that they must be non-zero if present (i.e. if aspect_ratio_idc == EXTENDED_SAR). I agree that it warrants a separate patch. > >> I would *maybe* check for X265_PARAM_BAD_NAME too, just in case they change >> the option name (however unlikely). > > Hmm, OK. Yeah, that was a definite maybe. I'd say maybe just log a warning instead of failing. That or drop the suggestion entirely, up to you. Patch LGTM otherwise. Tim _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
