On Wed, Apr 9, 2014 at 4:26 PM, Justin Ruggles <[email protected]> wrote: > On 04/09/2014 10:13 AM, Vittorio Giovara wrote: >> >> On Wed, Apr 9, 2014 at 2:58 PM, Luca Barbato <[email protected]> wrote: >>> >>> The default should be not to resample. >>> --- >>> libavcodec/mpegaudioenc.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/libavcodec/mpegaudioenc.c b/libavcodec/mpegaudioenc.c >>> index 3a5cdca..51a6f5b 100644 >>> --- a/libavcodec/mpegaudioenc.c >>> +++ b/libavcodec/mpegaudioenc.c >>> @@ -744,7 +744,6 @@ static int MPA_encode_frame(AVCodecContext *avctx, >>> AVPacket *avpkt, >>> >>> static const AVCodecDefault mp2_defaults[] = { >>> { "b", "384000" }, >>> - { "ar", "48000" }, >>> { NULL }, >>> }; >>> >> why? the 384k/48kHz is very common combination, and (most importantly) >> it's one of the few allowed >> whatever the resaon, libtwolame should get the same treatment. >> > > Because we should not be using a default sample rate for encoding in > general. The encoder already has a list of supported sample rates, which can > be used by the library user (and is used by avconv) to negotiate the which > sample rate to use.
Sounds fair (no pun intended). Luca please also remove this setting from libtwolame then. Cheers, -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
