Hi,
On Wed,  9 Apr 2014 18:50:03 +0200, Alessandro Ghedini <[email protected]> 
wrote:
> This adds a function to export raw replaygain values (i.e. in the (u)int32_t
> form). It first checks whether AV_PKT_DATA_REPLAYGAIN side data is present, in
> which case it does nothing.
> ---
>  doc/APIchanges           |  4 ++++
>  libavformat/replaygain.c | 29 ++++++++++++++---------------
>  libavformat/replaygain.h |  7 +++++++
>  libavformat/version.h    |  2 +-
>  4 files changed, 26 insertions(+), 16 deletions(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index ec1816a..7cd29b6 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -13,6 +13,10 @@ libavutil:     2013-12-xx
>  
>  API changes, most recent first:
>  
> +2014-04-xx - xxxxxxx - lavf 55.16.0 - replaygain.h
> +  Add ff_replaygain_export_raw() for exporting already decoded replaygain
> +  values.
> +

No need for this or the version bump, since this is just internal API, not
public.
You don't have to send a new patch for this, but keep it in mind for the future.

Otherwise looks fine.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to