On 2014-04-18 12:37:32 +0200, Hendrik Leppkes wrote: > On Fri, Apr 18, 2014 at 12:27 PM, Janne Grunau <[email protected]> wrote: > > On 2014-04-17 20:38:27 +0200, Anton Khirnov wrote: > >> > >> Any progress? > > > > Not fully convinced from patch below. Without changes in the stream > > get_format will be only called once. That might break applications > > using the codec context from avformat_find_stream_info. > > One the plus side it's non-ugly and adding support for all other codecs > > is a triviality. > > If its supposed to be the all-mighty place to init hwaccels, you also > need to call it when frame size changes, but pixel format stays the > same, so that the hwaccel gets a chance to re-init.
This is what happens when I pick up incomplete old changes without thinking why I didn't send them before. thanks for noticing. > Not sure if some hwaccels have other requirements to be notified of > certain changes. profile, levels, number of reference frames changes? BTW how are pixel bit depth and chroma subsampling changes handled? >From 9/10 bit 422/444 to 8bit 420 is not a problem from libavcodec's side since it calls get_format. But the other way might be strange since libavcodec forcefully chooses a software pixel format without calling get_format. I guess the get_buffer2? callback has to handle that correctly, sigh what a mess. Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
