On Tue, Apr 15, 2014 at 5:43 PM, Vittorio Giovara <[email protected]> wrote: > On Tue, Apr 15, 2014 at 3:32 PM, Justin Ruggles > <[email protected]> wrote: >> On 04/14/2014 11:16 PM, Vittorio Giovara wrote: >>> @@ -2502,7 +2503,7 @@ static int mov_read_tkhd(MOVContext *c, AVIOContext >>> *pb, MOVAtom atom) >>> for (i = 0; i < 3; i++) { >>> display_matrix[i][0] = avio_rb32(pb); // 16.16 fixed point >>> display_matrix[i][1] = avio_rb32(pb); // 16.16 fixed point >>> - avio_rb32(pb); // 2.30 fixed point (not used) >>> + display_matrix[i][2] = avio_rb32(pb); // 2.30 fixed point (not >>> used) >> >> It's used now. Update the comment accordingly. > > I left the comment because that column is saved but it's not used > anywhere in the code. > I can remove it if you prefer.
I removed it, and edited the comment above to // save u,v,z to store the whole matrix in the AV_PKT_DATA_DISPLAYMATRIX // side data, but the scale factor is not needed to calculate aspect ratio Thanks -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
