On Sun, Apr 20, 2014 at 9:38 PM, Anton Khirnov <[email protected]> wrote:
> Initial implementation by Andrew D'Addesio <[email protected]> during
> GSoC 2012.
>
> Completion by Anton Khirnov <[email protected]>, sponsored by the
> Mozilla Corporation.

yay, this looks super neat to me, I only found two minor nits worth of
mentioning.

> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index 5bd9778..9d6ea96 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -278,6 +278,9 @@ OBJS-$(CONFIG_NELLYMOSER_ENCODER)      += nellymoserenc.o 
> nellymoser.o
>  OBJS-$(CONFIG_NUV_DECODER)             += nuv.o rtjpeg.o
>  OBJS-$(CONFIG_PAF_VIDEO_DECODER)       += paf.o
>  OBJS-$(CONFIG_PAF_AUDIO_DECODER)       += paf.o
> +OBJS-$(CONFIG_OPUS_DECODER)            += opusdec.o opus.o opus_celt.o \
> +                                          opus_imdct.o opus_silk.o     \
> +                                          vorbis_data.o
>  OBJS-$(CONFIG_PAM_DECODER)             += pnmdec.o pnm.o
>  OBJS-$(CONFIG_PAM_ENCODER)             += pamenc.o
>  OBJS-$(CONFIG_PBM_DECODER)             += pnmdec.o pnm.o

diego-order-nit

> diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> index 47bbef5..904cecf 100644
> --- a/libavcodec/allcodecs.c
> +++ b/libavcodec/allcodecs.c
> @@ -327,6 +327,7 @@ void avcodec_register_all(void)
>      REGISTER_DECODER(MPC8,              mpc8);
>      REGISTER_ENCDEC (NELLYMOSER,        nellymoser);
>      REGISTER_DECODER(PAF_AUDIO,         paf_audio);
> +    REGISTER_DECODER(OPUS,              opus);
>      REGISTER_DECODER(QCELP,             qcelp);
>      REGISTER_DECODER(QDM2,              qdm2);
>      REGISTER_ENCDEC (RA_144,            ra_144);

diego-order-nit

Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to