On 2014-04-23 11:21:27 +0200, Christophe Gisquet wrote: > Hi, > > 2014-04-22 23:46 GMT+02:00 Janne Grunau <[email protected]>: > > The assembler source is due to extensive macro use uglier than I would > > like it to be but it's 4 functions in one. It looked nicer before I added > > double support. > [...] > > Really, we do that all over the place for x86. We also do this for > regular C code to mimic templating. > > I can't imagine anyone actually having to bother with more than > cosmetics to see this as an issue. It's probably harder to follow, but > it reduces code duplication and error probability so much it's IMO > very worth it.
I agree, not duplcating execution flow is good and I wasn't suggesting to expand the macros manually. I was more hoping for suggestions to make it less ugly. I might have a way to improve it. Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
