On 24/04/14 16:56, Aidan Skinner wrote:
> Hi,
>
> The mov muxer gets the Quicktime spec a little wrong with closed
> captions (https://bugzilla.libav.org/show_bug.cgi?id=664) to the
> extent Quicktime can't read them (and QT7 and MacCaption[1] choke
> entirely).
>
> I've attached a couple of patches which address some of the issues,
> and have a couple more WIP in github at
> https://github.com/aidan/libav/tree/clcp-cleanup which I'm still
> tidying up.
The set looks almost fine, just two points I'll address while pushing:
- the "tag:" before the patch subject should be a single word, in this
case "mov:" is the proper tag.
- if possible avoid idiomatic formatting such as
+ if (track->tag == MKTAG('t','e','x','t') || is_clcp_track(track))
+ mov_write_gmhd_tag(pb);
else mov_write_nmhd_tag(pb);
applying and reformatting now.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
