On 2 May 2014 05:08, Martin Storsjö <[email protected]> wrote: > On Fri, 2 May 2014, Josh Allmann wrote: > >> Currently, --disable-everything --enable-decoder=png won't actually >> enable the PNG decoder unless --enable-zlib is also specified. >> >> This patch implicitly enables zlib. >> --- >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 4f0a2eb..7bd700c 100755 >> --- a/configure >> +++ b/configure >> @@ -1807,8 +1807,8 @@ mxpeg_decoder_select="mjpeg_decoder" >> nellymoser_decoder_select="mdct sinewin" >> nellymoser_encoder_select="audio_frame_queue mdct sinewin" >> nuv_decoder_select="dsputil lzo" >> -png_decoder_deps="zlib" >> -png_encoder_deps="zlib" >> +png_decoder_select="zlib" >> +png_encoder_select="zlib" >> png_encoder_select="dsputil" >> prores_decoder_select="dsputil" >> prores_encoder_select="dsputil" >> -- >> 1.7.9.5 > > > With patches like this, you should be careful that this doesn't enable the > png decoder even though zlib actually isn't available (when it tries to > enable the png decoder/encoder). In this case, the deps do seem to be set up > in the right order, so that this doesn't happen, but it at least should be > checked. >
Short of setting up a zlib-less environment, configuring with the flags --disable-everything --enable-decoder=png --disable-zlib will keep png disabled, which is probably the right behavior. > In general we've got _dep and not _select for anything which is an external > dependency which we can't just "enable" like that (either it's explicitly > enabled, or we should not try to use it). zlib is the only exception to this > rule though; so given that, I might be ok with this change. But then we > should change all zlib dependencies to _select instead of _dep - not just > this random one. > OK, will update the rest of the zlib dependencies to use _select. > // Martin > > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
