On Tue, 13 May 2014, Janne Grunau wrote:

---
gas-preprocessor.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index f4a55a9..ab4294c 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -784,8 +784,9 @@ sub handle_serialized_line {
            $line = "        movi $1, $2, lsl #0\n";
        }
        # Xcode 5 misses the alias uxtl replace it with the more general ushll
-        if ($line =~ 
/^\s*uxtl(2)?\s+(v[0-3]?\d\.[248][hsdHSD])\s*,\s*(v[0-3]?\d\.(?:4|8|16)[bhsBHS])\b\s*$/)
 {
-            $line = "        ushll$1 $2, $3, #0\n";
+        # clang 3.4 misses the alias sxtl too replace it with the more general 
sshll

Nit: some punctuation would make the sentence a bit more readable (the same goes for the existing comment as well)

+        if ($line =~ 
/^\s*(s|u)xtl(2)?\s+(v[0-3]?\d\.[248][hsdHSD])\s*,\s*(v[0-3]?\d\.(?:2|4|8|16)[bhsBHS])\b\s*$/)
 {
+            $line = "        $1shll$2 $3, $4, #0\n";
        }
        if ($ENV{GASPP_FIX_XCODE5}) {
            if ($line =~ /^\s*bsl\b/) {
--
1.9.3

LGTM otherwise

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to