On 2014-05-13 20:23:55 +0300, Martin Storsjö wrote: > On Tue, 13 May 2014, Janne Grunau wrote: > > >Values are positive powers of two, so just replace it with right shift. > >--- > >libavcodec/aarch64/fft_neon.S | 2 +- > >1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/libavcodec/aarch64/fft_neon.S b/libavcodec/aarch64/fft_neon.S > >index 5189bfb..9802349 100644 > >--- a/libavcodec/aarch64/fft_neon.S > >+++ b/libavcodec/aarch64/fft_neon.S > >@@ -348,7 +348,7 @@ function fft\n\()_neon align=6 > > sub x0, x28, #\n4*2*8 > > ldp x28, x30, [sp], #16 > > movrel x4, X(ff_cos_\n) > >- mov x2, #\n4/2 > >+ mov x2, #\n4>>1 > > b fft_pass_neon > >endfunc > >.endm > >-- > >1.9.3 > > This is quite a big wtf - how come the tests have passed despite > this, so far? Or is this some other configuration than the clang-3.4 > on fate so far?
I think I accidentally lost -mpu=neon in the fate config which is for idiot reason required to compile/assemble with clang even on armv8. Just ignoring it without error is also quite WTF from clang's side. I haven't checked gaspp output but it works as intended with apple-clang. Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
