On Thu, May 15, 2014 at 2:29 AM, Anton Khirnov <[email protected]> wrote:
> Do not leave a non-zero extradata_size set on failure
> ---
>  libavformat/yop.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/yop.c b/libavformat/yop.c
> index 8caeb07..ea3175e 100644
> --- a/libavformat/yop.c
> +++ b/libavformat/yop.c
> @@ -62,13 +62,12 @@ static int yop_read_header(AVFormatContext *s)
>      video_stream = avformat_new_stream(s, NULL);
>
>      // Extra data that will be passed to the decoder
> -    video_stream->codec->extradata_size = 8;
>
> -    video_stream->codec->extradata = 
> av_mallocz(video_stream->codec->extradata_size +
> -                                                
> FF_INPUT_BUFFER_PADDING_SIZE);
> +    video_stream->codec->extradata = av_mallocz(8 + 
> FF_INPUT_BUFFER_PADDING_SIZE);
>
>      if (!video_stream->codec->extradata)
>          return AVERROR(ENOMEM);
> +    video_stream->codec->extradata_size = 8;
>
>      // Audio
>      audio_dec               = audio_stream->codec;


Seems ok, although when you get a memory error, there is little chance
to restore the situation afaik.
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to