Hello, 2014-06-03 9:01 GMT-04:00 Marc-Antoine ARNAUD <[email protected]>: Do you mind if we use your surname lowercase?
> > diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c > index c12491e..476ba0a 100644 > --- a/libavcodec/mpeg12enc.c > +++ b/libavcodec/mpeg12enc.c > @@ -286,6 +286,18 @@ static void mpeg1_encode_sequence_header(MpegEncContext > *s) > put_bits(&s->pb, 1, s->low_delay); > put_bits(&s->pb, 2, 0); // frame_rate_ext_n > put_bits(&s->pb, 5, 0); // frame_rate_ext_d > + > + put_header(s, EXT_START_CODE); > + put_bits(&s->pb, 4, 2); // sequence display > extension Please use the variable names as reported in the standard for the comments, it makes them easier to grep later on. > + put_bits(&s->pb, 3, 0); // video format: 0 is > components video_format > + put_bits(&s->pb, 1, 1); // color description colour_description > + put_bits(&s->pb, 8, s->avctx->color_primaries); // colorspace colour_primaries > + put_bits(&s->pb, 8, s->avctx->color_trc); // color transfer transfer_characteristics > + put_bits(&s->pb, 8, s->avctx->colorspace); // color matrix matrix_coefficients > + put_bits(&s->pb, 14, s->width); // display horizontal size display_horizontal_size > + put_bits(&s->pb, 1, 1); // marker marker_bit > + put_bits(&s->pb, 14, s->height); // display vertical size display_vertical_size > + put_bits(&s->pb, 3, 0); // remaining 3 bits are zero padding > } Finally please align the comments. The sizes and the values are correct, so LGTM otherwise. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
