On Wed, Jun 4, 2014 at 11:29 AM, Andrew Stone <[email protected]> wrote: > On Wed, Jun 4, 2014 at 11:17 AM, Vittorio Giovara > <[email protected]> wrote: >> On Wed, Jun 4, 2014 at 7:59 AM, Diego Biurrun <[email protected]> wrote: >>> --- >>> libavutil/dict.c | 4 ++-- >>> libavutil/dict.h | 6 +++--- >>> 2 files changed, 5 insertions(+), 5 deletions(-) >> >> Maybe I am wrong, but I think to remember that adding const to a >> public functions is an API break and therefore should be masked with a >> proper FF_API_. Similar to 5c439b41d0489412c0a4cf6dfb98915251677b8e. > > The commit you reference refers to returning a const type. Returning > consts will break the API because a const can't be implicitly cast to > a non-const. As a function parameter, it does not break the API as a > non-const pointer can implicitly become a const pointer.
Makes sense, thanks for clearing that out. Patch ok then. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
