On Thu, Jun 19, 2014 at 12:46 PM, Diego Biurrun <[email protected]> wrote: > On Thu, Jun 19, 2014 at 12:29:04PM +0200, Janne Grunau wrote: >> --- a/libavcodec/mpegvideo.c >> +++ b/libavcodec/mpegvideo.c >> @@ -391,6 +391,9 @@ av_cold int ff_dct_common_init(MpegEncContext *s) >> s->dct_unquantize_mpeg2_intra = dct_unquantize_mpeg2_intra_bitexact; >> s->dct_unquantize_mpeg2_inter = dct_unquantize_mpeg2_inter_c; >> >> + if (HAVE_INTRINSICS_NEON) >> + ff_MPV_common_init_neon(s); >> + >> if (ARCH_ARM) >> ff_MPV_common_init_arm(s); > > I suggest moving this below the ARCH_FOO block. > >> --- /dev/null >> +++ b/libavcodec/neon/mpegvideo.c >> @@ -0,0 +1,139 @@ >> + >> +#include <arm_neon.h> >> + >> +#include "libavutil/cpu.h" >> +#include "libavcodec/mpegvideo.h" >> + >> +#include "config.h" >> +#if ARCH_AARCH64 >> +#include "libavutil/aarch64/cpu.h" >> +#elif ARCH_ARM >> +#include "libavutil/arm/cpu.h" >> +#endif > > I'd suggest > > #include "config.h" > > #include "libavutil/cpu.h" > #if ARCH_AARCH64 > #include "libavutil/aarch64/cpu.h" > #elif ARCH_ARM > #include "libavutil/arm/cpu.h" > #endif
(nit) Also please indent the includes as https://wiki.libav.org/CodingStyle/HeaderOrdering -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
