On Mon, Jun 30, 2014 at 04:30:18PM +0200, Diego Biurrun wrote:
> On Mon, Jun 30, 2014 at 04:20:02PM +0200, Kostya Shishkov wrote:
> > On Mon, Jun 30, 2014 at 07:15:47AM -0700, Diego Biurrun wrote:
> > > This obviates a dependency of the LJPEG encoder on mpegvideo.
> > > ---
> > >
> > > Renamed everything to ljpeg, as suggested by Kostya.
> > >
> > > configure | 2 +-
> > > libavcodec/Makefile | 4 +-
> > > libavcodec/{mjpegenc.c => ljpeg.c} | 161 ++------------------
> > > libavcodec/ljpeg.h | 38 +++++
> > > libavcodec/ljpegenc.c | 27 +++-
> > > libavcodec/mjpegenc.c | 292
> > > +------------------------------------
> > > libavcodec/mjpegenc.h | 7 -
> > > libavcodec/mpegvideo_enc.c | 8 +-
> > > 8 files changed, 83 insertions(+), 456 deletions(-)
> > > copy libavcodec/{mjpegenc.c => ljpeg.c} (65%)
> > > create mode 100644 libavcodec/ljpeg.h
> >
> > Is it just me or you rename some encoding functions from ff_mjpeg_* to
> > ff_ljpeg_* and yet still use them for both (M)JPEG and LJPEG encoding?
>
> Yes, I do. I expect functions exported from ljpeg.c to live in the ljpeg
> namespace. Did I misunderstand your original suggestion? What is the
> alternative? Keep the mjpeg namespace?
If it's used in both then it is pure JPEG functions that should not be renamed
to Ljpeg namespace (and mjpegenc_common.[ch] would be more appropriate for
them).
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
