On Sat, 5 Jul 2014, Anton Khirnov wrote:
--- configure | 7 +++-- doc/APIchanges | 3 +++ libavcodec/Makefile | 8 +++--- libavcodec/dv.c | 4 +-- libavcodec/dv.h | 6 ++--- libavcodec/dv_profile.c | 57 +++++++++++++++++++++++++++++----------- libavcodec/dv_profile.h | 29 ++++++++++++++------ libavcodec/dv_profile_internal.h | 27 +++++++++++++++++++ libavcodec/dvdec.c | 2 +- libavcodec/dvenc.c | 1 + libavcodec/version.h | 4 +-- libavformat/dv.c | 15 ++++++----- libavformat/dvenc.c | 6 ++--- 13 files changed, 121 insertions(+), 48 deletions(-) create mode 100644 libavcodec/dv_profile_internal.hdiff --git a/configure b/configure index be97868..3ec8866 100755 --- a/configure +++ b/configure @@ -1534,6 +1534,7 @@ CONFIG_EXTRA=" bswapdsp cabac dsputil + dvprofile gcrypt golomb gplv3
The patch looks good to me, although I don't know this area in detail. Do I read the patch correctly that the new public avcodec functions always exist in a built library, but they're essentially no-ops unless some dv muxer/demuxer/encoder/decoder is enabled? That seems like a reasonable compromise to me, not bloating binaries for those users who do minimal builds, while still avoiding binaries that don't load in corner cases.
Nice that you remembered to keep the avpriv functions around until the next bump as well.
// Martin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
