On Sun, Jul 06, 2014 at 07:27:36PM +0530, Nidhi Makhijani wrote:
> --- /dev/null
> +++ b/libavcodec/vmdaudio.c
> @@ -0,0 +1,236 @@
> +/*
> + * Sierra VMD Audio Decoder

video decoder

Let's fix these typos since you change the lines anyway.

> + * Copyright (C) 2004 the ffmpeg project

These copyright statements are bogus, drop them.

> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>

I think only string.h is necessary for memset/memcpy.

> --- a/libavcodec/vmdav.c
> +++ b/libavcodec/vmdvideo.c
> @@ -1,5 +1,5 @@
>  /*
> - * Sierra VMD Audio & Video Decoders
> + * Sierra VMD Video Decoder
>   * Copyright (C) 2004 the ffmpeg project

see above

> @@ -31,21 +31,14 @@
>   * codec initialization. Each encoded frame that is sent to this decoder
>   * is expected to be prepended with the appropriate 16-byte frame
>   * information record from the VMD file.
> - *
> - * The audio decoder, like the video decoder, expects each encoded data
> - * chunk to be prepended with the appropriate 16-byte frame information
> - * record from the VMD file. It does not require the 0x330-byte VMD file
> - * header, but it does need the audio setup parameters passed in through
> - * normal libavcodec API means.
>   */
>  
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>

stdio.h and stdlib.h seem unused here as well.

> -#include "libavutil/channel_layout.h"
>  #include "libavutil/common.h"
> -#include "libavutil/intreadwrite.h"
> +

The video decoder also uses intreadwrite.h (AV_RL16).

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to