On 11/07/14 18:56, wm4 wrote: > On Fri, 11 Jul 2014 18:43:53 +0200 > Diego Biurrun <[email protected]> wrote: > >> On Fri, Jul 11, 2014 at 11:10:08AM -0400, Vittorio Giovara wrote: >>> --- a/doc/filters.texi >>> +++ b/doc/filters.texi >>> @@ -1034,6 +1034,9 @@ crop=out_w=in_w-100:out_h=in_h-100:x=100:y=100 >>> + >>> +# Make sure width and height are a multiple of 2 (rounding down) >>> +"crop=x=0:y=0:out_w=((in_w-1)/2)*2:out_h=((in_h-1)/2)*2" >> >> As was said on IRC already, this does not "make sure" that width and height >> are a multiple of 2. It reduces both even and odd values to the next smaller >> even value. I don't understand the scenario where this should be desirable. > > And as I said on IRC, this example is a major offense to the user. > > Not only does it look too complicated, it is too complicated. In fact, > it shouldn't be required at all, and vf_crop should have an option to do > the rounding automatically (according to the used pixel format). Most > things break if you feed it e.g. yuv420p with odd width or height, so > it'd be reasonable to enable such an option by default.
We can do that for sure. If you want to provide a patch would be great, otherwise remind me and I'll try to bake something. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
