On Fri, 18 Jul 2014, Luca Barbato wrote:

On 18/07/14 00:55, Vittorio Giovara wrote:
On Thu, Jul 17, 2014 at 6:51 PM, Luca Barbato <[email protected]> wrote:
Certain servers accept only PUT as valid method.
---
 libavformat/http.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/libavformat/http.c b/libavformat/http.c
index 948930a..5aa985d 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -43,6 +43,11 @@
 #define BUFFER_SIZE MAX_URL_SIZE
 #define MAX_REDIRECTS 8

+enum {
+    HTTP_POST,
+    HTTP_PUT
+};
+
 typedef struct {
     const AVClass *class;
     URLContext *hd;
@@ -85,6 +90,7 @@ typedef struct {
 #endif
     AVDictionary *chained_options;
     int send_expect_100;
+    char *write_method;

Shouldn't this be const?

Probably won't hurt.

Actually, I think we mostly have these as non-const. Otherwise we can't free it (without extra casting) if we want to change it from within the http protocol.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to