On Mon, Jul 21, 2014 at 02:53:07PM +0100, Ben Avison wrote: > --- /dev/null > +++ b/libavcodec/arm/startcode.h > @@ -0,0 +1,27 @@ > +/* > + * Copyright (c) 2014 RISC OS Open Ltd > + * Author: Ben Avison <[email protected]>
I suggest dropping copyright notices for such completely trivial files. > +#ifndef AVCODEC_ARM_STARTCODE_H > +#define AVCODEC_ARM_STARTCODE_H > + > +int ff_startcode_find_candidate_armv6(const uint8_t *buf, int size); > + > +#endif /* AVCODEC_ARM_STARTCODE_H */ This header will fail to compile standalone due to a missing stdint.h #include. Please run your commits through "make check". > --- /dev/null > +++ b/libavcodec/startcode.h > @@ -0,0 +1,35 @@ > +/* > + * Copyright (c) 2003-2010 Michael Niedermayer <[email protected]> same > +/** > + * @file > + * Accelerated start code search function for start codes common to > + * MPEG-1/2/4 video, VC-1, H.264/5 > + * @author Michael Niedermayer <[email protected]> > + */ I also suggest dropping duplicate Doxygen descriptions. > +#ifndef AVCODEC_STARTCODE_H > +#define AVCODEC_STARTCODE_H > + > +#include <stdint.h> > + > +int ff_startcode_find_candidate_c(const uint8_t *buf, int size); > + > +#endif /* AVCODEC_STARTCODE_H */ This header will compile, unlike the ARM one. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
