On Tue, Jul 22, 2014 at 08:28:35PM +0200, Hendrik Leppkes wrote: > Am 22.07.2014 19:49 schrieb "Janne Grunau" <[email protected]>: > > > > On 2014-07-22 04:03:02 -0700, Diego Biurrun wrote: > > > --- > > > > > > Changed to also replace the need_memalign variable in configure, which > > > essentially indicates the same thing. > > > > > > I've followed the git-blame path of STRIDE_ALIGN and an now confident > > > this is the correct solution for a number of hacks that were > cargo-culted > > > around. > > > > > > --- a/configure > > > +++ b/configure > > > @@ -1340,6 +1340,7 @@ ARCH_FEATURES=" > > > local_aligned_8 > > > local_aligned_16 > > > + simd_align_16 > > > " > > > BUILTIN_LIST=" > > > @@ -1701,8 +1702,7 @@ aligned_stack_if_any="aarch64 ppc x86" > x86_64" > > > fast_clz_if_any="aarch64 alpha avr32 mips ppc x86" > > > fast_unaligned_if_any="aarch64 ppc x86" > > > - > > > -need_memalign="altivec neon sse" > > > +simd_align_16_if_any="altivec neon sse" > > > > > > --- a/libavcodec/utils.c > > > +++ b/libavcodec/utils.c > > > @@ -189,7 +189,7 @@ int ff_side_data_update_matrix_encoding(AVFrame > *frame, > > > > > > -#if HAVE_NEON || ARCH_PPC || HAVE_MMX > > > +#if HAVE_SIMD_ALIGN_16 > > > # define STRIDE_ALIGN 16 > > > #else > > > # define STRIDE_ALIGN 8 > > > > the number in the define is a littly ugly but as long as we don't need > > to increase it to 32 or 64 for avx2/avx512/... this is fine > > But don't you need to do that eventually? > > Not sure Libav has any avx/2 yet that would need it, but iirc FFmpeg does > and bumped this variable to 32 conditionally on HAVE_AVX.
What's the problem? It's easy enough to add simd_align_32 ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
