On Sat, Jul 26, 2014 at 03:06:14PM +0100, Kieran Kunhya wrote:
> --- a/libavcodec/opus.c
> +++ b/libavcodec/opus.c
> @@ -290,10 +290,6 @@ av_cold int ff_opus_parse_extradata(AVCodecContext
> *avctx,
> OpusContext *s)
> {
> static const uint8_t default_channel_map[2] = { 0, 1 };
> - uint8_t default_extradata[19] = {
> - 'O', 'p', 'u', 's', 'H', 'e', 'a', 'd',
> - 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> - };
>
> int (*channel_reorder)(int, int) = channel_reorder_unknown;
>
> --- a/libavcodec/opus.h
> +++ b/libavcodec/opus.h
> @@ -61,6 +61,15 @@
> +
> +static const uint8_t av_opus_default_extradata[30] = {
> + 'O', 'p', 'u', 's', 'H', 'e', 'a', 'd',
> + 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> +};
There is no need to duplicate this table in decoder and parser.
Just move it to global scope in opus.c and add an extern declaration
to the header file.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
