On Sun, Aug 03, 2014 at 08:16:18PM +0200, Janne Grunau wrote:
> On 2014-08-03 18:06:04 +0200, Diego Biurrun wrote:
> > On Sun, Aug 03, 2014 at 04:37:05PM +0200, Janne Grunau wrote:
> > > --- a/libavutil/cpu.c
> > > +++ b/libavutil/cpu.c
> > > @@ -224,17 +228,50 @@ static const struct {
> > >
> > > +static void print_cpu_flags(int cpu_flags, const char *type)
> > > {
> > > int i;
> > >
> > > + fprintf(stderr, "cpu_flags(%s) = 0x%08X\n", type, cpu_flags);
> > > + fprintf(stderr, "cpu_flags_str(%s) =", type);
> >
> > What's the point of printing the string "type" twice?
>
> to make parsing easier
>
> > Could you paste some sample output?
>
> ./libavutil/cpu-test -cmmx -tauto
> cpu_flags(raw) = 0x000053DB
> cpu_flags_str(raw) = mmx mmxext sse sse2 sse3 ssse3 sse4.1 sse4.2 cmov
> cpu_flags(effective) = 0x00000001
> cpu_flags_str(effective) = mmx
> threads = auto (cpu_count = 4)
>
> The plan is to print cpu_flags_str(effective), threads and cpu_count on
> the report page.
LGTM
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
